Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPAddrBlock and ASIdentifiers extensions (RFC 3779) #4443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add IPAddrBlock and ASIdentifiers extensions (RFC 3779) #4443

wants to merge 1 commit into from
+1,347 −1

Conversation

arckoor
Copy link

@arckoor arckoor commented Nov 25, 2024

This PR implements two extensions required for working with secure routing. These extensions contain IP Addresses or AS numbers, as specified by RFC 3779.

Both encoding and decoding of AS numbers, single addresses, address prefixes and min-max ranges have been tested.

@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Coverage Status

coverage: 91.293% (+0.05%) from 91.245%
when pulling 1870a9c on arckoor:master
into e54502e on randombit:master.

@randombit
Copy link
Owner

@arckoor There are some CI failures which are relevant. Stylistically for calls to min,max where the compiler can’t deduce T we prefer std::min<T> vs use of casts.

@randombit
Copy link
Owner

@arckoor Remaining CI issues look related to the visibility annotations (eg BOTAN_PUBLIC_API) probably something is not being exported as a symbol.

@arckoor
Copy link
Author

arckoor commented Nov 27, 2024

@randombit We're currently chipping away at the fuzzers, but the visibility is also an issue. Previously linux/clang was failing, which I resolved by moving the definition of set_from_bytes to the .h file, the other errors could probably be solved by moving the rest there too, but that does not sound like a good solution to me. All of these errors are most likely related to the use of templates, though I don't know what the cleanest / recommended way to resolve them is.

@randombit
Copy link
Owner

@arckoor ok thanks. I’ll try to have a look over the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arckoor @coveralls @randombit